forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initialize the new app with a deep SMT instead of populating the empty SMT #267
Closed
Manav-Aggarwal
wants to merge
13
commits into
manav/fraudproof_with_isrs
from
manav/modify_new_apps_using_deepsmt
Closed
feat: Initialize the new app with a deep SMT instead of populating the empty SMT #267
Manav-Aggarwal
wants to merge
13
commits into
manav/fraudproof_with_isrs
from
manav/modify_new_apps_using_deepsmt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manav-Aggarwal
changed the title
Introduce new option to setSubstoreWithRoots
Initialize the new app with a deep SMT instead of populating the empty SMT on startup
Aug 20, 2022
Manav-Aggarwal
requested review from
adlerjohn,
jbowen93,
liamsi,
musalbas and
tzdybal
August 20, 2022 16:25
Manav-Aggarwal
changed the title
Initialize the new app with a deep SMT instead of populating the empty SMT on startup
feat: Initialize the new app with a deep SMT instead of populating the empty SMT on startup
Aug 20, 2022
Manav-Aggarwal
changed the title
feat: Initialize the new app with a deep SMT instead of populating the empty SMT on startup
feat: Initialize the new app with a deep SMT instead of populating the empty SMT
Aug 20, 2022
Manav-Aggarwal
force-pushed
the
manav/modify_new_apps_using_deepsmt
branch
from
August 22, 2022 17:40
f479416
to
677bdf4
Compare
Manav-Aggarwal
force-pushed
the
manav/modify_new_apps_using_deepsmt
branch
4 times, most recently
from
August 24, 2022 00:51
f1d43bc
to
3fbe9ff
Compare
Manav-Aggarwal
force-pushed
the
manav/modify_new_apps_using_deepsmt
branch
2 times, most recently
from
August 24, 2022 01:12
29ea7b5
to
ace0f6c
Compare
everything is moved to cosmos-sdk-rollmint repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a new baseapp is set from the contents of a fraudproof, when setting key/value pairs in the store of the baseapp, we start with an empty SMT with no predefined root. However, we must start with a deep SMT with a predefined root taken from the given fraudproof. This lets the new app's substore hashes to be the same.
Right now, since we load the key/value pairs on an empty SMT we don't get the same root as the pre-state root of a challenged transaction.
Closes: #266
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change